Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-build export symbols for shared libs on Windows #54

Merged
merged 1 commit into from
Nov 29, 2018

Conversation

yann-lty
Copy link
Member

@yann-lty yann-lty commented Nov 29, 2018

Without CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS set to ON (or explicit __export directives), the popsift.lib file is not generated when building shared libraries on Windows.

@fabiencastan fabiencastan merged commit aa77bd6 into develop Nov 29, 2018
@fabiencastan fabiencastan deleted the dev_autoExportSymbolsDLL branch November 29, 2018 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants