Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception handling #207

Merged
merged 31 commits into from
Jan 2, 2019
Merged

Exception handling #207

merged 31 commits into from
Jan 2, 2019

Commits on Dec 26, 2018

  1. Exception handling for backups (#206) 

    This commit covers:
  1. Specifying the backup path to an existing filename.
  2. KeyboardInterrupts at menus and prompts.
  3. When backing up packages, failed but installed commands (e.g., ls xxx/.cargo/bin) outputted their error messages to STDOUT.
  4. No need to clean up empty backup files now since we don't write to the packages' files if they're not installed.
  5. Because of #4, we needed to move npm's 2nd write section into an if so that it wouldn't try to remove a nonexistent file.
    Jason Phan committed Dec 26, 2018
    Configuration menu
    Copy the full SHA
    5b47b3c View commit details
    Browse the repository at this point in the history

  2. Exception handling for --new_path (#206) 

    I decided to exit here instead of reprompting like in path_update_prompt() because if you're using the
--new_path option you decided not to just use the regular path update prompt for some reason. I don't
really know why this option's a thing honestly because running shallow-backup with no arguments always
prompts you to update the path anyways.
    Jason Phan committed Dec 26, 2018
    Configuration menu
    Copy the full SHA
    1d279fd View commit details
    Browse the repository at this point in the history

  3. Typo in config dict key

    Jason Phan committed Dec 26, 2018
    Configuration menu
    Copy the full SHA
    59ba373 View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2018

  1. Fixed reinstalling packages w/ no package backups 

    Also got rid of unnecessary inner function.
    Jason Phan committed Dec 27, 2018
    Configuration menu
    Copy the full SHA
    a9b1956 View commit details
    Browse the repository at this point in the history

  2. coverage: trailing space

    Jason Phan committed Dec 27, 2018
    Configuration menu
    Copy the full SHA
    ecbfbe5 View commit details
    Browse the repository at this point in the history

Commits on Jan 1, 2019

  1. Added EOF blank line

    Jason Phan committed Jan 1, 2019
    Configuration menu
    Copy the full SHA
    289cb65 View commit details
    Browse the repository at this point in the history

  2. Updated to exit after no package backups are found

    Jason Phan committed Jan 1, 2019
    Configuration menu
    Copy the full SHA
    f436375 View commit details
    Browse the repository at this point in the history

  3. PEP8

    Jason Phan committed Jan 1, 2019
    Configuration menu
    Copy the full SHA
    41c6f99 View commit details
    Browse the repository at this point in the history

  4. got rid of extra EOL blank line

    Jason Phan committed Jan 1, 2019
    Configuration menu
    Copy the full SHA
    5a96b6c View commit details
    Browse the repository at this point in the history

  5. break to return

    Jason Phan committed Jan 1, 2019
    Configuration menu
    Copy the full SHA
    cb2b47e View commit details
    Browse the repository at this point in the history

  6. Refactored out existing file check into utils.py

    Jason Phan committed Jan 1, 2019
    Configuration menu
    Copy the full SHA
    28f40b6 View commit details
    Browse the repository at this point in the history

  7. PEP8

    Jason Phan committed Jan 1, 2019
    Configuration menu
    Copy the full SHA
    fb5cef6 View commit details
    Browse the repository at this point in the history

  8. Updated backup prompt to not be literal satan

    Jason Phan committed Jan 1, 2019
    Configuration menu
    Copy the full SHA
    5054d89 View commit details
    Browse the repository at this point in the history

  9. Added check for existing but empty package directories

    Jason Phan committed Jan 1, 2019
    Configuration menu
    Copy the full SHA
    11434b6 View commit details
    Browse the repository at this point in the history

  10. Fixed empty dir check and modified package error message

    Jason Phan committed Jan 1, 2019
    Configuration menu
    Copy the full SHA
    3783008 View commit details
    Browse the repository at this point in the history

  11. Updated existing file check function name 

    Co-Authored-By: bl0nd <xorblonded@gmail.com>
    @alichtman
    alichtman and bl0nd committed Jan 1, 2019
    Configuration menu
    Copy the full SHA
    ef21b41 View commit details
    Browse the repository at this point in the history

  12. Pulled renaming suggested change

    Jason Phan committed Jan 1, 2019
    Configuration menu
    Copy the full SHA
    4fc4841 View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2019

  1. Modified empty directory check condition

    Jason Phan committed Jan 2, 2019
    Configuration menu
    Copy the full SHA
    6947433 View commit details
    Browse the repository at this point in the history

  2. ternary up in here

    Jason Phan committed Jan 2, 2019
    Configuration menu
    Copy the full SHA
    89d425f View commit details
    Browse the repository at this point in the history

  3. renamed print_pkg_mgr_error()

    Jason Phan committed Jan 2, 2019
    Configuration menu
    Copy the full SHA
    65ae865 View commit details
    Browse the repository at this point in the history

  4. modified package error message

    Jason Phan committed Jan 2, 2019
    Configuration menu
    Copy the full SHA
    551f4a3 View commit details
    Browse the repository at this point in the history

  5. removed unnecessary parameters and updated function calls

    Jason Phan committed Jan 2, 2019
    Configuration menu
    Copy the full SHA
    2b90678 View commit details
    Browse the repository at this point in the history

  6. missing comma

    Jason Phan committed Jan 2, 2019
    Configuration menu
    Copy the full SHA
    e16c9f0 View commit details
    Browse the repository at this point in the history

  7. removed print_shell_cmd_error

    Jason Phan committed Jan 2, 2019
    Configuration menu
    Copy the full SHA
    6584ba7 View commit details
    Browse the repository at this point in the history

  8. Updated new_dir_is_valid to return bool

    Jason Phan committed Jan 2, 2019
    Configuration menu
    Copy the full SHA
    eaf0b9d View commit details
    Browse the repository at this point in the history

  9. updated to reflect new new_dir_is_valid()

    Jason Phan committed Jan 2, 2019
    Configuration menu
    Copy the full SHA
    ff1233a View commit details
    Browse the repository at this point in the history

  10. removed comment

    Jason Phan committed Jan 2, 2019
    Configuration menu
    Copy the full SHA
    ee9343d View commit details
    Browse the repository at this point in the history

  11. Updated error message

    Jason Phan committed Jan 2, 2019
    Configuration menu
    Copy the full SHA
    6c7f9fa View commit details
    Browse the repository at this point in the history

  12. moved empty backup dir check into function

    Jason Phan committed Jan 2, 2019
    Configuration menu
    Copy the full SHA
    92adb5b View commit details
    Browse the repository at this point in the history

  13. updated empty_backup_dir_check() message

    Jason Phan committed Jan 2, 2019
    Configuration menu
    Copy the full SHA
    e9ae1aa View commit details
    Browse the repository at this point in the history

  14. Fix error message.

    @alichtman
    alichtman committed Jan 2, 2019
    Configuration menu
    Copy the full SHA
    2031741 View commit details
    Browse the repository at this point in the history