-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ruby support #292
Add ruby support #292
Conversation
The reinstallation fails on my system. $ gem list | tail -n+1 | sed 's/(/--version /' | sed 's/)//' | xargs -L 1 gem install
ERROR: While executing gem ... (Gem::Requirement::BadRequirementError)
Illformed requirement ["default:"]
ERROR: While executing gem ... (Gem::Requirement::BadRequirementError)
Illformed requirement ["default:"]
ERROR: While executing gem ... (Gem::Requirement::BadRequirementError)
Illformed requirement ["default:"]
Fetching bundler-unload-1.0.2.gem
Successfully installed bundler-unload-1.0.2
Parsing documentation for bundler-unload-1.0.2
Installing ri documentation for bundler-unload-1.0.2
Done installing documentation for bundler-unload after 0 seconds
1 gem installed
ERROR: While executing gem ... (Gem::Requirement::BadRequirementError)
Illformed requirement ["default:"]
ERROR: While executing gem ... (Gem::Requirement::BadRequirementError)
Illformed requirement ["default:"]
ERROR: While executing gem ... (Gem::Requirement::BadRequirementError)
Illformed requirement ["default:"]
ERROR: While executing gem ... (Gem::Requirement::BadRequirementError)
Illformed requirement ["default:"]
ERROR: While executing gem ... (Gem::Requirement::BadRequirementError)
Illformed requirement ["default:"]
ERROR: While executing gem ... (Gem::Requirement::BadRequirementError)
Illformed requirement ["default:"]
I think there's probably a better format to keep the install list in that would make it easy to reinstall from. Additionally, please send tested PRs, and definitely make a note if it is untested / there are bugs. |
Interesting, it was working earlier when I was testing it on my machine, perhaps there was a recent change in |
return process.returncode | ||
else: | ||
print_path_red("An error occurred while running: $", command) | ||
print_yellow("Package manager not present.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
print_yellow("Package manager not present.") | |
print_path_red("An error occurred while running: $", command) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense to keep the error messages in run_cmd_write_stdout
pretty abstract. It's a util function, and we let the calling function know of the error with the error code returned. A more specific error message can be printed from there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, though there won't be an error code to check in this case, as a FileNotFoundError
results in a return of None
. I can change it to something like Command not found
, which is a bit more general and accurate to what a return of None
represents.
Hmm, interesting. I'm using |
My latest commit fixes the issue, just had to update the backup command. |
@tim-coutinho Sorry for taking so long to get around to this. Rebase off |
This addresses #38.