README update #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groundskeeper doesn't play that nicely with minified code. doing this makes sure that `groundskeeper-brunch` is run before in brunch's optimization step.
|
FYI, I ended up using UglifyJS' Uglify is more well-maintained, stable and widely used library. I would try to direct users ending up here to check that out instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
groundskeeper doesn't play that nicely with minified code.
doing this makes sure that
groundskeeper-brunchis run before in brunch's optimization step.I got a problem where I had some code which, when obfuscated was
[..],console.log('something'),[..]and groundskeeper removed theconsole.logbut kept both the commas, resulting in a syntax error when run.