Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve MQTT #349

Merged
merged 2 commits into from Feb 20, 2024
Merged

Improve MQTT #349

merged 2 commits into from Feb 20, 2024

Conversation

Minims
Copy link
Contributor

@Minims Minims commented Feb 15, 2024

  • Improve device data in MQTT integration
  • Does not retain camera config by default.

@roleoroleo
Copy link
Collaborator

I can't test it now, because my yi_home is down.
But a couple of questions:

  • Is get_system_config() necessary? It seems she's never called
  • Line 91: variable HTTPD_PORT is empty (maybe it requires get_system_config()?).
  • Line 92: echo $DEVICE_DETAILS. Is it a typo?

If I can restore the cam tonight I will test it.

@roleoroleo
Copy link
Collaborator

roleoroleo commented Feb 15, 2024

We should shed some light on the mqtt world.
There is a big overlap between mqttv4+mqtt-config and mqtt_adv_homeassistant.sh.

@Minims
Copy link
Contributor Author

Minims commented Feb 15, 2024

  • Is get_system_config() necessary? It seems she's never called
  • Line 91: variable HTTPD_PORT is empty (maybe it requires get_system_config()?).
  • Line 92: echo $DEVICE_DETAILS. Is it a typo?

I have fixed those 3 things :-).

@alienatedsec alienatedsec merged commit d6ea4fa into alienatedsec:pre-release-0.4.1x Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants