Swagger generation for JObject fails (due to IDictionary cast)

[JoschaMetze]

If a model class for an operation contains a JObject property (or JObject itself) the generation fails with an index out of bounds exception. I suppose this is linked to schema.AdditionalProperties = type.GetGenericArguments()[1].ToOpenApiSchema();(line 61 of OpenApiSchemaExtensions.cs) as JObject implements IDictionary but has no generic arguments itself.

I suggest either checking for JObject itself (as you are already referencing Newtonsoft.Json in that file) or checking if the count of arguments from GetGenericArguments exceeds 1.

Thanks
Joscha

[justinyoo]

@JoschaMetze Thanks for the comment! Would you give me some example code snippet so that I can reproduce the error on my side, please?

[JoschaMetze]

Hey, of course, minimal repro:
does work

 [OpenApiOperation("FunctionWorks")] 
        [OpenApiResponseBody(HttpStatusCode.Unauthorized, "text/plain", typeof(string))]
        [OpenApiResponseBody(HttpStatusCode.OK, "application/json", typeof(string))]
public static object FunctionWorks(){}

does not work

 [OpenApiOperation("FunctionFails")] 
        [OpenApiResponseBody(HttpStatusCode.Unauthorized, "text/plain", typeof(string))]
        [OpenApiResponseBody(HttpStatusCode.OK, "application/json", typeof(JObject))]
public static object FunctionFails(){}

[justinyoo]

@JoschaMetze Both JObject and Dictionary can't be declared at the root level like the example code above, because they don't have name. But both can be a property of a class like:

AzureFunctions.Extensions/src/Aliencube.AzureFunctions.FunctionAppCommon/Models/SampleModel.cs

Line 53 in 75c770c

public Dictionary<string, string> Collection { get; set; } = new Dictionary<string, string>();

AzureFunctions.Extensions/src/Aliencube.AzureFunctions.FunctionAppCommon/Models/SampleModel.cs

Line 58 in 75c770c

public JObject JsonObject { get; set; } = new JObject();

[justinyoo]

@JoschaMetze I'll close this for now. If you need further discussion, please feel free to open this again.

[justinyoo]

@JoschaMetze Now both JObject and JToken are properly rendered.

[JoschaMetze]

Thanks for fixing that 👍