IConverterSettings simplified; DownloadMethod issue resolved #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
now there is no need to have config requirement, we may use any ConverterSettings class that can created not from config, but i.e. from DB 2) DownloadMethod issue corrected now DownloadMethod sends correctly (as bool or as string)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@justinyoo , thanks for that great CloudConverter Wrapper.
I've found some issues (listed below) with Settings and DownloadMethod and I've tried to resolve them. If You would find my changes useful and reliable, please commit them in the project.
Anyway, I would appreciate Your feedback.
Best regards,
Ivan Litskevich.
IConverterSettings simplified
The issue was, that the only way to specify settings was to have .config with appropriate settings.
Now there is no need to have config requirement, because we may use any ConverterSettings class (nested by IConverterSettings) that can be created not from .config, but i.e. from DB or dynamically from the code. Only requirement for that class - is to have 3 main properties (ApiKey, ProcessUrl and UseHeader).
DownloadMethod issue resolved
The issue was, that some values (true or false) were serialized as a string (i.e.: "download":"false"), that caused wrong server-side interpretation (these values wasn't parsed on the server correctly and in some cases in response we could have a converted file - wrong behavior).
Now DownloadMethod sends correctly (as bool or as string) depending on the value (thanks to Json Custom Serialization attribute option).