Return most /authorize errors as a redirect #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The spec defines that most errors to `/authorize` should be returned to
the redirect URI with `error` and `error_description` query params:
If the resource owner denies the access request or if the request
fails for reasons other than a missing or invalid redirection URI,
the authorization server informs the client by adding the following
parameters to the query component of the redirection URI using the
"application/x-www-form-urlencoded" format, per Appendix B:
Add `InvalidRedirectURIError` and use `InvalidClientError` for all
`client_id` errors since these should not redirect. Update
`catch_errors_and_unavailability` to optionally return errors as
redirects.
mgorven
requested review from
synchronizing,
danygielow and
woile
as code owners
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #71 +/- ##
==========================================
- Coverage 99.66% 99.38% -0.29%
==========================================
Files 14 14
Lines 602 650 +48
Branches 86 96 +10
==========================================
+ Hits 600 646 +46
- Misses 1 2 +1
- Partials 1 2 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Hi @mgorven ! Thank you for your great catch and your PRs. I'll take a look at them today. |
aliev
approved these changes
Feb 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec defines that most errors to
/authorizeshould be returned to the redirect URI witherroranderror_descriptionquery params:Add
InvalidRedirectURIErrorand useInvalidClientErrorfor allclient_iderrors since these should not redirect. Updatecatch_errors_and_unavailabilityto optionally return errors as redirects.