Release 1.1.0 #16
Merged
Release 1.1.0 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to also account for "mod installed but game not launched yet" as position file is only created on game launched
|
1 above seems to work, but sometimes (with Mumble 1.5) the PA information flashes blank (imagine this screen but everything resets to 0 for a single frame)
I am unsure why this happens, or what effect this could have on the audio. It might manifest as a short-and-loud BLIP of being able to hear everybody's audio, or multiple blips as different people's contexts change, and are thus audible to everyone for a single frame. |
|
I cannot test 2 above without more people. The screenshot from the above comment shows that it displays the coordinates correctly, though. |
|
I tested this with 1 other person 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #13, #14
this might introduce problems in future if file read error is encountered for a different reason other than "was reading file when Factorio tried to write it"
to be tested. sets z coordinate to 1000x surface index. Max distance on Mumble is 200 units of distance, so you shouldn't be able to hear cross-surface