Use the same winAscent and winDescent across the family

aliftype · Dec 3, 2022 · 23d6eb0 · 23d6eb0
1 parent eb865a1
commit 23d6eb0
Show file tree

Hide file tree

Showing 8 changed files with 11 additions and 19 deletions.
diff --git a/fonts/Amiri-Bold.ttf b/fonts/Amiri-Bold.ttf
diff --git a/fonts/Amiri-BoldItalic.ttf b/fonts/Amiri-BoldItalic.ttf
diff --git a/fonts/Amiri-Italic.ttf b/fonts/Amiri-Italic.ttf
diff --git a/fonts/Amiri-Regular.ttf b/fonts/Amiri-Regular.ttf
diff --git a/fonts/AmiriQuran.ttf b/fonts/AmiriQuran.ttf
diff --git a/fonts/AmiriQuranColored.ttf b/fonts/AmiriQuranColored.ttf
diff --git a/scripts/build.py b/scripts/build.py
@@ -383,8 +383,8 @@ def makeQuran(options):
     # bigger font bbox that the regular fonts.
     head = otf["head"]
     os_2 = otf["OS/2"]
-    os_2.usWinAscent = head.yMax
-    os_2.usWinDescent = abs(head.yMin)
+    os_2.usWinAscent = max(head.yMax, os_2.usWinAscent)
+    os_2.usWinDescent = max(abs(head.yMin), os_2.usWinDescent)
 
     otf.save(options.output)
 

diff --git a/sources/Amiri.glyphs b/sources/Amiri.glyphs
@@ -1,5 +1,5 @@
 {
-.appVersion = "3139";
+.appVersion = "3148";
 customParameters = (
 {
 name = hheaAscender;
@@ -26,6 +26,14 @@ name = typoLineGap;
 value = 0;
 },
 {
+name = winAscent;
+value = 1850;
+},
+{
+name = winDescent;
+value = 910;
+},
+{
 name = underlinePosition;
 value = -512;
 },
@@ -6389,14 +6397,6 @@ ascender = 1124;
 capHeight = 646;
 customParameters = (
 {
-name = winAscent;
-value = 1814;
-},
-{
-name = winDescent;
-value = 898;
-},
-{
 name = postscriptFullName;
 value = Amiri;
 },
@@ -6419,14 +6419,6 @@ ascender = 1124;
 capHeight = 646;
 customParameters = (
 {
-name = winAscent;
-value = 1822;
-},
-{
-name = winDescent;
-value = 906;
-},
-{
 name = postscriptFullName;
 value = "Amiri Bold";
 },