Fixed new selector .rc -> .tF2Cxc #8
Conversation
Google is randomly seeding the results with selectors named .rc and .tF2Cxc, the rollout seems to be random. This change adds code to iterate through a list of hardcoded selectors and look for the correct selector. There may be a more elegant and adaptive way of doing this, but this works presently, though it will need periodic updating when they break it.
Skip the .rc selector and just go straight to .yuRUbf
|
Works, thanks! |
|
@aligo - Please merge this fix. Thank you. |
|
I confirm the fix. Thanks @drwonky . |
|
@aligo - Hello. It's been two weeks already. Every time Google changes something, your userscript breaks. And instead of you updating the userscript, someone else has to come and explain what is wrong and how to fix it. And then we have to copy and paste the new code. So then we end up with two userscripts. Yours, that doesn't work. And a new one, that is temporary. And because we want the official userscript and not the modified one that other people helped us make, we have to keep checking again and again and again and again to see if you updated your userscript yet. It's been two weeks. It's a simple fix. Drwonky already did the work for you. All you have to do is take five minutes to log in and merge his changes. Why are you always doing this to us? This isn't the first time that it took you almost a month to make a tiny change. At this point, you should make Drwonky a collaborator on your GitHub so he can just do the work for you since you are always MIA. Please. I'm begging you. Make him your collaborator (Contributor) already. |
I have forked his project and will continue to maintain my fork as needed so that I may contribute back. This is open source and that means anyone can participate on their own. Castigating the creator will not make him work faster, only make him not want to participate any longer. I understand that Google's changes make it difficult for users of his script, but it's Google that is breaking things, not him. Please respect the creator and what he has done, disrespecting him increases the likelihood he will simply abandon the project. |
Blah blah blah blah. More lecturing, virtue signaling nonsense. I'm complaining because it takes him one month to merge a tiny fix that someone made for him. If he cares so little and does so much, at this point him abandoning it will do no harm because it is like he already abandoned it. Which is why I recommend that he let you take over. As for you forking his project. I saw that you were listed in the Forks, but when I visited your Fork page, I didn't see anything. Do you have a GreaseMonkey userscript link or something where I can add your userscript to my browser and get automatic updates (without having to wait for HIM to take 1-2 months to update)? I figure you'd update yours more regularly. Oh yeah, I have two words for you. Wonder if you can figure out what they are? Hint: First one starts with an 'F'. |
|
I don't mean to hijack this, but I decided to fork this and create a greasyfork link: https://greasyfork.org/en/scripts/420865-better-google-drwonky The author seems to be on hiatus and may not be able to merge pull requests for some time. |
Google is randomly seeding the results with selectors named .rc and .tF2Cxc, the rollout seems to be random.
This change eliminates the intermediate selector .g .rc and simply iterates over .g .yuRUbf instead.
This jumps down level in the DOM and eliminates a future source of maintenance.