Add line missing line ending.

[davidolrik]

When reassembling the lines, no line ending were added to the last line.
This caused the following line to be pulled up unto the last line of the selected block.

[alimony]

I cannot reproduce this, could you give me an example of a block of lines and what part to select before doing the sort? I could only make it happen by selecting the lines I wanted to sort and also including the last line break, i.e. selecting up until the first position of the next not selected line, if that makes any sense.

[davidolrik]

If I select a block of lines and sort, as shown in the first image, the last line is moved up.
Doing the same, with the build in sorting functions does not move the last line up.

[davidolrik]

Your explanation makes total sense, and that is usually how I select lines to sort.
I position the cursor on the first line I want to select, and then do ⇧🔽 until I have select all the lines I want.

[alimony]

Sounds entirely reasonable to mimic the built-in sort behavior, so this change should look if the last character is a line ending and only add one if there was one before. Otherwise it would add an unwanted line ending if the selection is up to the last character of the last line instead.

[davidolrik]

Agreed, I have updated my pull request to respect the last character(s) of the region.

[alimony]

I think it can be much simpler, something like:

if self.view.substr(region).endswith(line_ending_character):
    output += line_ending_character

I hope you are not annoyed by my suggestions :)

[alimony]

Also reminds me that I should really add some tests…

[davidolrik]

Not annoyed at all 😄
I'm all for deleting code, and keeping it simple, I have updated my pull request with your suggestion.
Works as expected.

[alimony]

Great, this is perfect. Will merge it as soon as I'm on my main computer and can test it one last time myself.

[alimony]

Haha, look what Gmail did to that smiley in the notification email:

That is one messed up guy!

[davidolrik]

Jabba the smiley! (...or more likely his sister)