Skip to content

Commit

Permalink
Add more issue templates
Browse files Browse the repository at this point in the history
  • Loading branch information
alin23 committed Dec 18, 2019
1 parent 81b95cd commit 74bf3fd
Show file tree
Hide file tree
Showing 3 changed files with 60 additions and 2 deletions.
31 changes: 31 additions & 0 deletions .github/ISSUE_TEMPLATE/lunar-bug.md
@@ -0,0 +1,31 @@
---
name: Lunar Bug
about: Template for reporting bugs
title: "Lunar Bug"
labels: bugs
assignees: alin23

---

# Issue details
- Mac device where Lunar is installed (Macbook Pro 2019, iMac, Mac Mini, Hackintosh etc.):
*write response here*

- Monitor model (LG UltraFine 5K, DELL P2715Q etc.):
*write response here*

- Monitor connection to the Mac device (HDMI-to-USB-C, USB-C-to-USB-C, miniDisplayPort-to-DisplayPort etc.):
*write response here*

- Using an USB Docking Station or Hub:
*write yes or no here*

- Lunar mode used (check it in the top-right corner of the Lunar interface)
*Sync, Location or Manual*

- (only if you know how to compile a C program) Does this utility work for you? https://github.com/kfix/ddcctl
*optional response*


# Issue description:
*write a short description of what doesn't work as expected*
25 changes: 25 additions & 0 deletions .github/ISSUE_TEMPLATE/lunar-feature.md
@@ -0,0 +1,25 @@
---
name: Lunar Feature
about: Template for requesting features
title: "Lunar Feature"
labels: features
assignees: alin23

---

### Name of the feature

*give a name to your wanted feature*

### What problem does this feature solve?

*describe what doesn't work as it should now, and how this feature would solve that*

### How should the feature work

*describe the way you would want this to work, as detailed as possible*

### Visual description

*if this is a UI change, try to add an image of how you think this should look like*

6 changes: 4 additions & 2 deletions Lunar/AppDelegate.swift
Expand Up @@ -891,13 +891,15 @@ class AppDelegate: NSObject, NSApplicationDelegate, CLLocationManagerDelegate, N
}

guard let url = response.value, !url.isEmpty,
let urlEncoded = url.addingPercentEncoding(withAllowedCharacters: .urlHostAllowed) else {
let urlEncoded = url.addingPercentEncoding(withAllowedCharacters: .urlHostAllowed),
let serialNumberHash = getSerialNumberHash(),
let appVersion = (Bundle.main.infoDictionary?["CFBundleShortVersionString"] as? String)?.addingPercentEncoding(withAllowedCharacters: .urlHostAllowed) else {
log.error("Debug data upload response empty")
self.failDebugData()
return
}
log.info("Uploaded logs to \(url)")
if let url = URL(string: "https://github.com/alin23/Lunar/issues/new?assignees=alin23&labels=diagnostics&template=lunar-diagnostics-report.md&title=Lunar+Diagnostics+Report+%5B\(urlEncoded)%5D") {
if let url = URL(string: "https://github.com/alin23/Lunar/issues/new?assignees=alin23&labels=diagnostics&template=lunar-diagnostics-report.md&title=Lunar+Diagnostics+Report+%5B\(urlEncoded)%5D+%5B\(serialNumberHash)%5D+%5B\(appVersion)%5D") {
NSWorkspace.shared.open(url)
}
})
Expand Down

0 comments on commit 74bf3fd

Please sign in to comment.