Disable ui menu controller #258
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are modifying the Webview component to include a custom event that will be fired once the user has selected text and presses the comment button on the context menu that appears. This event is handled by a callback that is assigned to the event from javascript code.
Hide Highlight option in tooltip
Decrease the default deceleration rate of webview to normal
Disable Share menu
This commit modifies `onSelection` event and sends an extra field `selectionAction` to javascript.
Enable highlight in MenuController
Update iOS header imports for RN > 0.40
Import `PropTypes` from `prop-types`
Use createReactClass instead of React.createClass
Use createReactClass instead of React.createClass
This will stop those default `copy`, `cut` and `share` options from coming up. Instead of using a default UIWebview we are subclassing it and overriding `canPerformAction` to return NO. This will make this webview to not add any options to the `UIMenuController` that pops up when user selects a text. According to the responder chain, everything will then be up the next view in heirarchy, in this case, RCTWebViewBridge, where we already have the code to show our custom actions -- `highlight` and `comment`, and nothing else.
Subclass webview to override `canPerformAction`
This commit overrides the default behaviour for double tap. We now expose an api `onDoubleTap`, to react-native, which will receive an event with the location of the tap.
Override the default double tap gesture recognizer of webview
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't show UIMenuController when there is a text selection.