Fixes #272: messages.forEach is not a function #273
Conversation
Fixes and tested working in RN 0.51
> multiple methods named 'goForward' found with mismatched result, parameter type or attributes in RCTWebViewBridgeManager.m, line 89 Changes match other RCT_EXPORT_METHODs, like goBack above
|
@fungilation Thx.I will check |
|
FYI, I've been committing multiple fixes to my fork, which all lumped into initial PR for fixing #272. |
There was a problem hiding this comment.
@chansuke I can test this merged PR once it's merged to master, for any breakage in my app.
Thanks for merging this and other PRs!
ios/RCTWebViewBridgeManager.h
Outdated
| @@ -14,7 +14,6 @@ | |||
| #import <React/RCTUIManager.h> | |||
| // #import <React/RCTBridge.h> // in forked https://github.com/lefnire/react-native-webview-bridge | |||
|
|
|||
| #import "RCTWebViewBridge.h" | |||
There was a problem hiding this comment.
Why is this deleted?
There was a problem hiding this comment.
Ok, imports moved around. I can test once this changes are merged, for any breakage in my app.
| WebViewBridgeManager | ||
| } | ||
| WebViewBridgeManager, | ||
| }, | ||
| } = ReactNative; | ||
| var { PropTypes } = PropTypes; |
There was a problem hiding this comment.
This line should be deleted, redundant with var PropTypes = require('prop-types'). Can be used as is.
Same thing in index.android.js
| @@ -17,6 +17,7 @@ var React = require('react'); | |||
| React.createClass = require('create-react-class'); | |||
There was a problem hiding this comment.
This line should be deleted, only createReactClass is used
| @@ -18,6 +18,7 @@ var React = require('react'); | |||
| React.createClass = require('create-react-class'); | |||
There was a problem hiding this comment.
This line should be deleted, only createReactClass is used
webview-bridge/index.android.js
Outdated
| @@ -37,7 +37,7 @@ var { | |||
| WebViewBridgeManager | |||
| } | |||
| } = ReactNative; | |||
| var PropTypes = require('prop-types'); | |||
| var { PropTypes } = PropTypes; | |||
There was a problem hiding this comment.
This line should be deleted, redundant like in index.ios.js
|
Ok,I'll merge this then.Thank you for your work. |
|
Cool. I see a npm bump too (after 2 years!) But what about the 5 changes/cleanup I suggested in review above? |
|
@fungilation Thanks for the confirmation and your feedbacks. Well, I'm planning to merge these changes/cleanups in Thanks so much for your work. |
Fixes #272
This is more of a bandaid. Should investigate how is messages getting malformed