Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use WebView from react-native-webview as it has been deprecated from … #289

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cj3g10
Copy link

@cj3g10 cj3g10 commented Feb 26, 2019

Use WebView from react-native-webview as it has been deprecated from react-native and will be removed in future release.

See https://facebook.github.io/react-native/docs/webview for more info.

Copy link
Contributor

@fungilation fungilation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for this before WebView deprecation in RN 0.59+

Hard for me to review changes in index.ios.js by just looking at diff, due to a lot of code re-ordering. I'll test later and comment. I assume you have tested this PR in your own app?

@cj3g10
Copy link
Author

cj3g10 commented Feb 26, 2019

Yes, I'm currently using this PR in my own app.
I thought I turned off my formatting add-on, so I didn't realize index.ios.js had a lot of code re-ordering.

@cj3g10
Copy link
Author

cj3g10 commented Feb 27, 2019

One more thing: I think we will also need to add react-native link react-native-webview to the install instructions.

@fungilation
Copy link
Contributor

One more thing: I think we will also need to add react-native link react-native-webview to the install instructions.

Yup. @chansuke merge please?

@fungilation
Copy link
Contributor

fungilation commented Apr 19, 2019

@chansuke? Is no one maintaining this again?

I confirm this PR works perfectly in my app WonderSwipe, and is needed for RN 0.59.5. Please merge.

@vendicto
Copy link

@fungilation Could you merge it?

@fungilation
Copy link
Contributor

Nope. No write access.

@rosmcmahon
Copy link

this still needs to be fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants