Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transcluded templates break $compile #9

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

zoltan-papp
Copy link

Transcluded templates break $compile

Bug visible here, with ion-toggle: http://codepen.io/zoltan_papp/pen/dovGVo?editors=101

  • moved the linking function into compile prelinking,
  • before the linking (and compiling), I make a copy of the affixed element, save the pure HTML.
  • instead of recompiling the code in every scroll, moved that part to the initialization phrase
  • instead of markup changes, just show and hide the affixed element

Please consider these changes!
Cheers,
Zoli

Moved the linking function into compile prelinking, but before the linking, I make a copy of the affixed element.
Instead of recompiling the code in every scroll, moved that part to the initialization phrase, and just hiding and showing the compiled part.
Transcluded templates break $compile cycle
Bugfix to not trigger the scrollchange functions where there were no scrollchange at all
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant