Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Pipx Support #702

Closed
3 tasks done
mediatech15 opened this issue Nov 29, 2022 · 7 comments · Fixed by #704
Closed
3 tasks done

[FEATURE] Pipx Support #702

mediatech15 opened this issue Nov 29, 2022 · 7 comments · Fixed by #704

Comments

@mediatech15
Copy link

  • I am requesting a feature.
  • I am running the latest version of BDfR
  • I have read the Opening an issue

Description

I would like support for installing via pipx. This should be easy as it is just a console script definition for setup.py

This would allow installation in a non-global manor or the need to not create a venv for the tool. Pipx handles venv/path/binary setup along with ability to specify the python version if your default is incompatible. I currently have 6 python versions and 3.7 is default for work purposes/personal development.

I may be able to submit a PR for this if needed.

@mediatech15 mediatech15 changed the title Pipx Support [FEATURE] [FEATURE] Pipx Support Nov 29, 2022
@OMEGARAZER
Copy link
Contributor

@mediatech15 I have a console entry point set up with some other changes I'm working on atm. As I don't use pipx I'm unsure if there's anything else that is needed on top of that though, are you aware of any by chance? If not I'll try my best to dig into pipx and test what I have.

@mediatech15
Copy link
Author

@OMEGARAZER This is their docs https://pypa.github.io/pipx/how-pipx-works/
There is a section for developing for pipx.
Not much more than what you mentioned. Idea of when that would be rolled in?

@OMEGARAZER
Copy link
Contributor

Fully rolled in, not sure, but I'll dig into it this evening and test what I have.

If things go well I should be able to do a PR with just those changes.

@mediatech15
Copy link
Author

Awesome If you make the PR and want an additional tester I can do that. Tag me in the PR.

@mediatech15
Copy link
Author

@Serene-Arc Is there a planned release in the near future? I didn't see in the docs anything about typical release schedule so I'm assuming its as needed or when time permits?

OMEGARAZER referenced this issue in OMEGARAZER/bulk-downloader-for-reddit-x Nov 30, 2022
Adds support for pipx with console entry point.

closes #702
Serene-Arc added a commit that referenced this issue Dec 1, 2022
@mediatech15
Copy link
Author

Thanks all I successfully installed via pipx targeting development branch.

@Serene-Arc
Copy link
Collaborator

Excellent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants