Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modeling_qwen attention not use multi branch position ids & attention_mask #27

Open
snippetzero opened this issue Jun 5, 2024 · 1 comment

Comments

@snippetzero
Copy link

I reviewed the code of modeling_qwen.py, and I noticed that, within the lookahead process, the draft_ids matched from the TrieTree are such that the attention_mask and position ids associated with these draft_ids are not being utilized in the attention mechanism. This, I believe, might be an implementation error. Could you please point out where my understanding is incorrect?

@YunjiaXi
Copy link

YunjiaXi commented Jul 3, 2024

I believe there are issues with modeling_qwen.py. The content generated by Qwen differs significantly when using lookahead compared to when it is not used. With lookahead, the output text becomes much longer and exhibits incoherence. After fixing the attention mask issue you mentioned, the text became much more coherent, but there are still substantial differences in the content generated. I think there are still some unresolved problems in this code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants