Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #95 #96

Closed
wants to merge 2 commits into from
Closed

fix #95 #96

wants to merge 2 commits into from

Conversation

QilongZhang
Copy link
Contributor

No description provided.

caojie09
caojie09 reviewed Jun 28, 2018
View reviewed changes
runtime-sofa-boot-starter/pom.xml
<artifactId>selenium-java</artifactId>
<version>2.53.1</version>
<scope>test</scope>
</dependency>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以不加这个依赖，然后自己写一个 BeanFactoryPostProcessor 复现这个问题嚒？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@caojie09 嗯，好的，我改下。

@coveralls
Copy link

coveralls commented Jun 28, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 267

  • 9 of 11 (81.82%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 72.212%
Changes Missing Coverage Covered Lines Changed/Added Lines %
runtime-sofa-boot-starter/src/main/java/com/alipay/sofa/runtime/spring/factory/ReferenceFactoryBean.java 3 5 60.0%
Totals Coverage Status
Change from base Build 266: -0.002%
Covered Lines: 2305
Relevant Lines: 3192
💛 - Coveralls

@QilongZhang
Copy link
Contributor Author

我把这个 PR 关闭，#95 的问题将会提前在 2.4.1 版本修复。

@QilongZhang QilongZhang deleted the factory_bean_interface branch July 4, 2018 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caojie09 caojie09 caojie09 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@QilongZhang @coveralls @caojie09