Skip to content
This repository has been archived by the owner on May 30, 2022. It is now read-only.

optimize registry type #183

Merged
merged 7 commits into from
May 23, 2019
Merged

optimize registry type #183

merged 7 commits into from
May 23, 2019

Conversation

leizhiyuan
Copy link
Contributor

@leizhiyuan leizhiyuan commented May 21, 2019

Motivation:

fixes #182
fixes #173

Modification:

Describe the idea and modifications you've done.

Result:

Fixes #.

If there is no issue then describe the changes introduced by this PR.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@0b21cef). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #183   +/-   ##
=========================================
  Coverage          ?   59.23%           
  Complexity        ?      457           
=========================================
  Files             ?       59           
  Lines             ?     1862           
  Branches          ?      325           
=========================================
  Hits              ?     1103           
  Misses            ?      547           
  Partials          ?      212
Impacted Files Coverage Δ Complexity Δ
...lipay/sofa/rpc/boot/config/ConsulConfigurator.java 64.1% <100%> (ø) 6 <1> (?)
.../alipay/sofa/rpc/boot/config/MeshConfigurator.java 100% <100%> (ø) 3 <1> (?)
...ay/sofa/rpc/boot/config/LocalFileConfigurator.java 80% <100%> (ø) 6 <1> (?)
...ay/sofa/rpc/boot/SofaBootRpcAutoConfiguration.java 95.83% <100%> (ø) 18 <0> (?)
...alipay/sofa/rpc/boot/config/NacosConfigurator.java 100% <100%> (ø) 3 <1> (?)
...ay/sofa/rpc/boot/config/ZookeeperConfigurator.java 100% <100%> (ø) 4 <1> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b21cef...bafbd40. Read the comment docs.

@leizhiyuan leizhiyuan added this to the 6.0.1 milestone May 22, 2019
@leizhiyuan leizhiyuan requested review from NeGnail and ujjboy May 22, 2019 02:50
Copy link
Member

@ujjboy ujjboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leizhiyuan leizhiyuan merged commit 77f3fe6 into sofastack:master May 23, 2019
@leizhiyuan leizhiyuan modified the milestones: 6.0.1, 6.0.2 May 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants