Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep last_build_profile in sync with profile requested in manifest #1049

Merged
merged 5 commits into from
Jun 23, 2022
Merged

Keep last_build_profile in sync with profile requested in manifest #1049

merged 5 commits into from
Jun 23, 2022

Conversation

mosteo
Copy link
Member

@mosteo mosteo commented Jun 8, 2022

Fixes #1040

Fabien-Chouteau
Fabien-Chouteau reviewed Jun 9, 2022
View reviewed changes
testsuite/tests/build_profile/last_profile/test.py

# Check implicit profile when build is indirect

run_alr("run") # Causes a default build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if alr run should keep the last build profile.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, it's probably more intuitive that way. I'll add that change.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But in a follow-up patch

@mosteo
Copy link
Member Author

mosteo commented Jun 22, 2022

I'm stuck trying to fix the errors in the testsuite. For starters, it seems to depend on the compiler version: I don't get those with Ubuntu's 20 compiler (9.x) but I do with 11.2. And then, when I run the test steps by hand, I don't get the exception either.

I guess something in the test environment is having something to do, but event trying to set up it by hand in advance is not working.

Glad for any ideas on what to try.

@mosteo mosteo force-pushed the fix/build-profile branch 3 times, most recently from 13f240b to cecfce8 Compare June 22, 2022 17:35
@mosteo
Copy link
Member Author

mosteo commented Jun 22, 2022

So after some trial and error, the only "simple" solution I could find was to manually manage and trigger the finalization of the new Configuration field in the Root record. Since this is functionally equivalent, I find it all very suspect.

@mosteo mosteo marked this pull request as ready for review June 22, 2022 18:18
@mosteo mosteo merged commit de1d655 into alire-project:master Jun 23, 2022
@mosteo mosteo deleted the fix/build-profile branch June 23, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fabien-Chouteau Fabien-Chouteau Fabien-Chouteau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

alr config return wrong build profile when override is in manifest
3 participants
@mosteo @Fabien-Chouteau @actions-user