Minor improvements to solver progress output #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosteo
force-pushed
the
fix/solving-message
branch
3 times, most recently
from
b660491
to
f0054f0
Compare
Remove duplicate messages, and add progress while we are still in the space of complete solutions (as nothing was reported if no complete solution was found).
Fabien-Chouteau
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove duplicate messages, and add progress while we are still in the space of complete solutions (as nothing was being reported if no complete solution was found, giving the impression of alr being stuck for some seconds).
The duplicates were of the kind:
"Solving dependencies... Solving dependencies... Solving dependencies..."(There was one per completeness level attempted.)