Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow missing configuration values until build #1167

Merged
merged 3 commits into from
Sep 22, 2022

Conversation

mosteo
Copy link
Member

@mosteo mosteo commented Aug 30, 2022

This way we can normally get/without crates without defaults, but at the time of building the values must be set.

Fixes #1125

@mosteo mosteo marked this pull request as ready for review August 30, 2022 15:08
@mosteo mosteo added this to the 1.2.2 milestone Aug 31, 2022
Copy link
Member

@Fabien-Chouteau Fabien-Chouteau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch looks ok but I am not sure about the solution used here.

In particular I don't like that the config files will be generated but only partially.
Could we skip entirely the config generation on the get step?

@mosteo
Copy link
Member Author

mosteo commented Sep 21, 2022

Changed to avoid generating files in case of incompleteness. Also renamed a Map to Var_Map to be a bit more meaningful.

@mosteo mosteo merged commit 256a97d into alire-project:master Sep 22, 2022
@mosteo mosteo deleted the feat/skip-config branch September 22, 2022 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unset configuration variables in CI
3 participants