Test alr from project dir #1262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0rzech
force-pushed
the
test-alr-from-project-dir
branch
4 times, most recently
from
7f04dad
to
fe7f46a
Compare
0rzech
force-pushed
the
test-alr-from-project-dir
branch
2 times, most recently
from
a169e48
to
b939210
Compare
Use Polish letter 'ł' to make user input validation test explicitly mention encoding problems when failing.
0rzech
force-pushed
the
test-alr-from-project-dir
branch
from
b939210
to
8296af5
Compare
mosteo
approved these changes
Dec 13, 2022
|
Looks good to me, thanks. @Fabien-Chouteau , do you think this is safe? |
|
This can be also confusing if one wants to test another build, but it's a better default I guess. |
|
Makes sense. That can be added as a further improvement. |
|
Thanks, @0rzech . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1260.