alire_common.gpr: remove default host os to avoid mistakes on macOS #1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the default being Linux, macOS users will not notice any issue until they try to use the executable. Even then the issue will be obscure.
|
This might trigger some build issues... |
|
Then I think it will be better to remove reliance on Note to self: this will require fixing the |
mosteo
force-pushed
the
no-default-host-os
branch
2 times, most recently
from
46bd760
to
f1f438d
Compare
This should avoid misbuilds that mix Linux/macOS. A bash function is now provided for detection of the OS in our scripts.
mosteo
force-pushed
the
no-default-host-os
branch
from
f1f438d
to
c60524e
Compare
|
I've removed any guess attempts from I think we're good to go if you don't see any issue in my changes, @Fabien-Chouteau |
mosteo
approved these changes
Jan 28, 2023
This was referenced Jan 28, 2023
Closed
Merged
|
Looks good to me 👍 Thanks for picking that up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the default being Linux, macOS users will not notice any issue until they try to use the executable. Even then the issue will be obscure.