Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update getting-started.md #1343

Merged
merged 3 commits into from
Mar 14, 2023
Merged

Update getting-started.md #1343

merged 3 commits into from
Mar 14, 2023

Conversation

corinthian13
Copy link
Contributor

@corinthian13 corinthian13 commented Mar 10, 2023

Lines 12 - 15.

More clarity on how to add PATH entry for Alire ecosystem client installed on a user's local Linux machine.
PATH value was missing the double quotes that may be needed when file paths contain spaces, e.g. /home/me/ada stuff/alr/bin.

Lines 12 - 15.

More clarity on how to add PATH entry for Alire ecosystem client installed on a user's local Linux machine. 
PATH value was missing the required double quotes.
@@ -9,9 +9,9 @@ repository](https://github.com/alire-project/alire/releases).

On Linux, `Alire` is simply provided in an archive.

Once the archive is extracted you have to add `alr` in the environment `PATH`:
Once the archive is extracted you have to add `alr` in the environment `PATH`in the .bashrc file of the user's home directory:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure everyone will want to put that in .bashrc. I personally prefer to set the PATH every time I want to use Alire.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then I suppose it's a case of an either ... or ... depending on the user's choice.
Personally I would see no danger in having this additional path entry and a lot of convenience in retaining it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be reworded as to indicate that it's an optional possibility and not a requirement for use.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edited as per mosteo suggestion.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this belongs in a setup-environment.md document.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jquorning

Why not where it is right now, i.e. the "Getting Started" page ?
https://github.com/alire-project/alire/blob/master/doc/getting-started.md

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not where it is right now, i.e. the "Getting Started" page ?

I guess the environment is a big matrix of combinations of terminals, character sets, shells, configurations, etcetera not controlled by Alire. Especially on Linux. IMO Alire should not try to adapt to all kinds of specialized use cases internally.

To offer users a choice of adding the Alire client environment to their PATH environment either just for their current terminal session or for future sessions also.
Put PATH entries into .profile rather than .bashrc since some users may not be using the bash shell, i.e. may be using csh, zsh, fsh, etc.
@mosteo mosteo merged commit e5acf1a into alire-project:master Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants