Add GPR externals and env. vars. to build hash computation #1428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fabien-Chouteau
approved these changes
Sep 1, 2023
| -- Externals modified but not declared are presumably for the | ||
| -- benefit of another crate. It's unclear if these will affect | ||
| -- the crate doing the setting, so we err on the side of | ||
| -- caution and include them in the hashing. Maybe we could make |
There was a problem hiding this comment.
I think it's good to include them.
|
|
||
| -- Environment variables | ||
| -- TBD | ||
|
|
||
| -- Configuration variables | ||
| -- TBD | ||
|
|
||
| -- Dependencies recursive hash? Since a crate can use a dependency | ||
| -- config spec, it is possible in the worst case for a crate to |
There was a problem hiding this comment.
Indeed, I think that's something I already do in my project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turned out a bit uglier than anticipated because when hashing the environment being set by the crate, it may depend on the own crate dir (via
$CRATE_DIR), which in turn depends now on the build hash being computed.So we have to break the circularity and skip these substitutions when we are still computing the build hash.