Fix bugs for corner cases with shared dependencies #1453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosteo
force-pushed
the
fix/bug-system-crate
branch
from
b20aa8d
to
07bc9ed
Compare
Fabien-Chouteau
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked dependencies on their own were giving trouble if no other regular dependencies forced config generation. Also the selfbuild of
alrby itself uncovered another corner case with linked dependencies. Test included.Also I introduced a bug in #1448 because I removed one of two consecutive arguments with boolean defaults, which made calls passing only the first boolean to unsuspectedly use it for the second. Note to self: don't use boolean parameters with defaults in such a way.