Merge publishing assistant PRs into master #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Suppress warnings on unused package at top level * First complete minimal publishing workflow Only for repositories, many checks still missing, like: whitelist, version conflict, buildability... * Also working with source archives * Deprecate --hash, --commit Instead, the commit is simply a second optional argument * Give upload URL for the PR and place manifest in ... ...alire/releases * Check if in workspace for proper file placement and also discourage publishing a crate within an unrelated workspace. * Disable --hash test * Tests for publishing and fixes for detected errors To test without resorting to actual remote sources, we use --force which allows local (file:) URLs. * Workaround for Windows temporary failed deletion Something about a git repository makes Ada.Directories.Delete_Tree to fail (my guess that this is git related).
* Initial list of trusted code hosts * Test that an unknown domain is rejected * Fixes for testsuited-detected problems on Windows
* Add switch to print the list of trusted git sites
* Show release information for user review We also point out any recommended optional properties that are not informed. Checks on completeness are also performed. * Test missing/optional properties during publish Also refactor some bulky code in a test to reusable drivers.helpers.py
* Test build the release * Test that failing build is reported * Fix zipping helper in testsuite The extra indirection level was not required, as os.walk already gives us the proper paths we need. This wasn't detected until we tried to build an unzipped release zipped by ourselves.
* Publish using local repo and revision as reference We still require the remote is ready (in essence, that the local repo is not ahead of the remote), but now it is simply a matter of issuing `alr publish` or `alr publish <commit|tag|branch>`, and the corresponding commit will be used. * Refactor long function name to more sensible one * Fix comments due to bad refactoring * Test for publishing from inside a repo * Fixes uncovered by testsuite Adding defaults for <URL> <commit> complicates things somewhat as we use local paths for testing that would otherwise be rejected, so a few corner cases have to be explicitly considered now.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
And spellcheck fixes
mosteo
force-pushed
the
merging/publish
branch
from
faa993a
to
b372688
Compare
* Document the new `alr publish` workflow * Review changes
Fabien-Chouteau
approved these changes
Sep 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And summarize changes in the user log (last commit).
To be merged after bringing in #524.