Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge publishing assistant PRs into master #527

merged 9 commits into from Sep 14, 2020

Merge publishing assistant PRs into master #527

merged 9 commits into from Sep 14, 2020


Copy link

@mosteo mosteo commented Sep 14, 2020

And summarize changes in the user log (last commit).

To be merged after bringing in #524.

mosteo added 7 commits Sep 12, 2020
* Suppress warnings on unused package at top level

* First complete minimal publishing workflow

Only for repositories, many checks still missing, like: whitelist, version
conflict, buildability...

* Also working with source archives

* Deprecate --hash, --commit

Instead, the commit is simply a second optional argument

* Give upload URL for the PR and place manifest in ...


* Check if in workspace for proper file placement

and also discourage publishing a crate within an unrelated workspace.

* Disable --hash test

* Tests for publishing and fixes for detected errors

To test without resorting to actual remote sources, we use --force which allows
local (file:) URLs.

* Workaround for Windows temporary failed deletion

Something about a git repository makes Ada.Directories.Delete_Tree to fail (my
guess that this is git related).
* Initial list of trusted code hosts

* Test that an unknown domain is rejected

* Fixes for testsuited-detected problems on Windows
* Add switch to print the list of trusted git sites
* Show release information for user review

We also point out any recommended optional properties that are not informed.
Checks on completeness are also performed.

* Test missing/optional properties during publish

Also refactor some bulky code in a test to reusable
* Test build the release

* Test that failing build is reported

* Fix zipping helper in testsuite

The extra indirection level was not required, as os.walk already gives us the
proper paths we need. This wasn't detected until we tried to build an unzipped
release zipped by ourselves.
* Publish using local repo and revision as reference

We still require the remote is ready (in essence, that the local repo is not
ahead of the remote), but now it is simply a matter of issuing `alr publish` or
`alr publish <commit|tag|branch>`, and the corresponding commit will be used.

* Refactor long function name to more sensible one

* Fix comments due to bad refactoring

* Test for publishing from inside a repo

* Fixes uncovered by testsuite

Adding defaults for <URL> <commit> complicates things somewhat as we use local
paths for testing that would otherwise be rejected, so a few corner cases have
to be explicitly considered now.
@mosteo mosteo marked this pull request as ready for review Sep 14, 2020
@mosteo mosteo requested a review from Fabien-Chouteau Sep 14, 2020
* Document the new `alr publish` workflow

* Review changes
@mosteo mosteo merged commit 8d8dde6 into master Sep 14, 2020
@mosteo mosteo deleted the merging/publish branch Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants