fix empty client ID on request #1182

alireza0 · Apr 18, 2024 · 7258cbf · 7258cbf
1 parent cf9e09e
commit 7258cbf
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/web/service/inbound.go b/web/service/inbound.go
@@ -588,7 +588,7 @@ func (s *InboundService) UpdateInboundClient(data *model.Inbound, clientId strin
 
 	oldEmail := ""
 	newClientId := ""
-	clientIndex := 0
+	clientIndex := -1
 	for index, oldClient := range oldClients {
 		oldClientId := ""
 		if oldInbound.Protocol == "trojan" {
@@ -609,7 +609,7 @@ func (s *InboundService) UpdateInboundClient(data *model.Inbound, clientId strin
 	}
 
 	// Validate new client ID
-	if newClientId == "" {
+	if newClientId == "" || clientIndex == -1 {
 		return false, common.NewError("empty client ID")
 	}