Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump .NET to 7.0 #57

Merged
merged 1 commit into from Dec 1, 2022
Merged

chore: bump .NET to 7.0 #57

merged 1 commit into from Dec 1, 2022

Conversation

sondr3
Copy link
Contributor

@sondr3 sondr3 commented Nov 29, 2022

Description

Updated supported .NET versions to 6.0 and 7.0. Closes #56.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works
  • I have made corresponding changes to the documentation
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes
  • I did test corresponding changes on Windows
  • I did test corresponding changes on Linux
  • I did test corresponding changes on Mac

@alirezanet
Copy link
Owner

alirezanet commented Nov 29, 2022 •
edited

Hi @sondr3,
Thank you for the PR 💐.
One question. why did you remove net5.0 support? I think dropping net 5.0 support is unnecessary unless you have a good reason for it.

@alirezanet alirezanet added the enhancement New feature or request label Nov 29, 2022
@alirezanet alirezanet added this to the 0.6.0 milestone Nov 29, 2022
@alirezanet alirezanet self-requested a review November 29, 2022 21:59
@sondr3
Copy link
Contributor Author

sondr3 commented Nov 30, 2022

I figured that since .NET 5 is EOL bumping to the two latest releases was fine, but if you feel like this is unnecessary I happily change it back.

@alirezanet
Copy link
Owner

alirezanet commented Nov 30, 2022 •
edited

I figured that since .NET 5 is EOL bumping to the two latest releases was fine, but if you feel like this is unnecessary I happily change it back.

Yes please, I know a few people are still using Dotnet 5 in their company, so there is no rush to remove it for me.

alirezanet
alirezanet requested changes Nov 30, 2022
View reviewed changes
Copy link
Owner

@alirezanet alirezanet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything looks good.
Just please uncomment the husky attach commands.

src/Husky/Husky.csproj Outdated Show resolved Hide resolved
@sondr3 sondr3 force-pushed the dotnet-7 branch 2 times, most recently from 08e54b8 to 6638dd6 Compare December 1, 2022 09:33
alirezanet
alirezanet approved these changes Dec 1, 2022
View reviewed changes
tests/HuskyTest/HuskyTest.csproj
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
<TargetFrameworks>net7.0</TargetFrameworks>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a blocker, but this should be <TargetFramework>

@alirezanet alirezanet merged commit 6751c8f into alirezanet:master Dec 1, 2022
@alirezanet
Copy link
Owner

Great, thank you 💐🙏

@sondr3 sondr3 deleted the dotnet-7 branch December 1, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alirezanet alirezanet alirezanet approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.

Support .NET 7.0
2 participants
@sondr3 @alirezanet