Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(install): git submodule handling #81

Merged
merged 1 commit into from Aug 20, 2023

Conversation

Tychus
Copy link
Contributor

@Tychus Tychus commented Aug 20, 2023

Description

Husky so far is unable to handle install on submodules. This PR attempts to solve that by adding:

  1. IgnoreSubmodule option to both attach and install which will either prevent the whole target from being executed (same as Husku = 1) or in the case of install make it break the installation process if it detects it's a submodule.
  2. When IgnoreSubdmoule is not specified the install command will then attach the husky hooks to the correct .git directory which is not .git in the case of submodules.

See more details here #69

Fixes issue (#69)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works
  • I have made corresponding changes to the documentation
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes
  • I did test corresponding changes on Windows
  • I did test corresponding changes on Linux
  • I did test corresponding changes on Mac

Copy link
Owner

@alirezanet alirezanet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 💐
LGTM 🚀

@alirezanet alirezanet merged commit 4aef278 into alirezanet:master Aug 20, 2023
1 check passed
@alirezanet
Copy link
Owner

Hi @Tychus,
I merged the PR since this is not a blocker to this feature ... but if you have time please add corresponding information to the documentations also, would make it easier for others to use your feature.
and thank you for your contribution.

@Tychus Tychus deleted the feature/SubmoduleHandling branch August 20, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants