Fix version comparison of Werkzeug #24

Merged
merged 1 commit into from Jan 30, 2015

Conversation

Projects
None yet
4 participants
@mtsgrd
Contributor

mtsgrd commented Jan 30, 2015

The existing comparison breaks flask_limiter when Werkzeug==0.10 is installed.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jan 30, 2015

Coverage Status

Coverage remained the same at 100.0% when pulling 8f5fdcb on YoApp:master into a2eb928 on alisaifee:master.

Coverage Status

Coverage remained the same at 100.0% when pulling 8f5fdcb on YoApp:master into a2eb928 on alisaifee:master.

alisaifee added a commit that referenced this pull request Jan 30, 2015

Merge pull request #24 from YoApp/master
Fix version comparison of Werkzeug

@alisaifee alisaifee merged commit f2c44a8 into alisaifee:master Jan 30, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@alisaifee

This comment has been minimized.

Show comment
Hide comment
Owner

alisaifee commented Jan 30, 2015

Thanks @mtsgrd

@g-p-g

This comment has been minimized.

Show comment
Hide comment
@g-p-g

g-p-g Jan 30, 2015

Contributor

Wouldn't it be better to use pkg_resources.parse_version(...) so it avoids an unnecessary import?

Contributor

g-p-g commented Jan 30, 2015

Wouldn't it be better to use pkg_resources.parse_version(...) so it avoids an unnecessary import?

@mtsgrd

This comment has been minimized.

Show comment
Hide comment
@mtsgrd

mtsgrd Jan 30, 2015

Contributor

@g-p-g you're right. It could look like this:

pkg_resources.get_distribution("werkzeug").parsed_version < pkg_resources.parse_version("0.9")
Contributor

mtsgrd commented Jan 30, 2015

@g-p-g you're right. It could look like this:

pkg_resources.get_distribution("werkzeug").parsed_version < pkg_resources.parse_version("0.9")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment