Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version comparison of Werkzeug #24

Merged
merged 1 commit into from Jan 30, 2015

Conversation

@mtsgrd
Copy link
Contributor

mtsgrd commented Jan 30, 2015

The existing comparison breaks flask_limiter when Werkzeug==0.10 is installed.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 30, 2015

Coverage Status

Coverage remained the same at 100.0% when pulling 8f5fdcb on YoApp:master into a2eb928 on alisaifee:master.

alisaifee added a commit that referenced this pull request Jan 30, 2015
Fix version comparison of Werkzeug
@alisaifee alisaifee merged commit f2c44a8 into alisaifee:master Jan 30, 2015
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@alisaifee

This comment has been minimized.

Copy link
Owner

alisaifee commented Jan 30, 2015

Thanks @mtsgrd

@g-p-g

This comment has been minimized.

Copy link
Contributor

g-p-g commented Jan 30, 2015

Wouldn't it be better to use pkg_resources.parse_version(...) so it avoids an unnecessary import?

@mtsgrd

This comment has been minimized.

Copy link
Contributor Author

mtsgrd commented Jan 30, 2015

@g-p-g you're right. It could look like this:

pkg_resources.get_distribution("werkzeug").parsed_version < pkg_resources.parse_version("0.9")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.