Use strong reference to storage in strategy

alisaifee · Apr 17, 2023 · 8a3ec0f · 8a3ec0f
1 parent e434204
commit 8a3ec0f
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/limits/aio/strategies.py b/limits/aio/strategies.py
@@ -2,7 +2,6 @@
 Asynchronous rate limiting strategies
 """
 
-import weakref
 from abc import ABC, abstractmethod
 from typing import cast
 
@@ -15,7 +14,7 @@
 class RateLimiter(ABC):
     def __init__(self, storage: StorageTypes):
         assert isinstance(storage, Storage)
-        self.storage: Storage = weakref.proxy(storage)
+        self.storage: Storage = storage
 
     @abstractmethod
     async def hit(self, item: RateLimitItem, *identifiers: str, cost: int = 1) -> bool:

diff --git a/limits/storage/memory.py b/limits/storage/memory.py
@@ -7,7 +7,7 @@
 from limits.typing import Dict, List, Optional, Tuple
 
 
-class LockableEntry(threading._RLock):
+class LockableEntry(threading._RLock):  # type: ignore
     def __init__(self, expiry: float) -> None:
         self.atime = time.time()
         self.expiry = self.atime + expiry

diff --git a/limits/strategies.py b/limits/strategies.py
@@ -2,7 +2,6 @@
 Rate limiting strategies
 """
 
-import weakref
 from abc import ABCMeta, abstractmethod
 from typing import Dict, Type, Union, cast
 
@@ -14,7 +13,7 @@
 class RateLimiter(metaclass=ABCMeta):
     def __init__(self, storage: StorageTypes):
         assert isinstance(storage, Storage)
-        self.storage: Storage = weakref.proxy(storage)
+        self.storage: Storage = storage
 
     @abstractmethod
     def hit(self, item: RateLimitItem, *identifiers: str, cost: int = 1) -> bool: