Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support authentication through storage string for redis cluster #154

Merged
merged 2 commits into from
Jan 24, 2023

Conversation

alisaifee
Copy link
Owner

@alisaifee alisaifee commented Jan 24, 2023

Description

If username/password are provided in the storage string uri for redis cluster a parsing error occurs and infact there is no provision to extract the authentication details from the string.

Related issues

@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Base: 96.91% // Head: 96.61% // Decreases project coverage by -0.31% ⚠️

Coverage data is based on head (c06039b) compared to base (68ee7f6).
Patch coverage: 73.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #154      +/-   ##
==========================================
- Coverage   96.91%   96.61%   -0.31%     
==========================================
  Files          25       25              
  Lines        1168     1180      +12     
  Branches      123      127       +4     
==========================================
+ Hits         1132     1140       +8     
- Misses         18       20       +2     
- Partials       18       20       +2     
Impacted Files Coverage Δ
limits/aio/storage/redis.py 93.79% <71.42%> (-1.18%) ⬇️
limits/storage/redis_cluster.py 95.83% <75.00%> (-4.17%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alisaifee alisaifee merged commit a92ea21 into master Jan 24, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix-cluster-auth-from-uri branch January 24, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant