Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test cleanup #58

Closed
wants to merge 3 commits into from
Closed

Test cleanup #58

wants to merge 3 commits into from

Conversation

alisaifee
Copy link
Owner

No description provided.

@alisaifee alisaifee self-assigned this May 29, 2020
@coveralls
Copy link

Coverage Status

Coverage decreased (-39.9%) to 59.417% when pulling 7c6af04 on cleanup-tests into 5ce9256 on master.

@codecov
Copy link

codecov bot commented Jun 7, 2020

Codecov Report

Merging #58 into master will decrease coverage by 41.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #58       +/-   ##
===========================================
- Coverage   99.29%   58.25%   -41.04%     
===========================================
  Files          12       12               
  Lines         424      424               
===========================================
- Hits          421      247      -174     
- Misses          3      177      +174     
Impacted Files Coverage Δ
limits/storage/memcached.py 31.14% <0.00%> (-68.86%) ⬇️
limits/storage/redis_sentinel.py 32.25% <0.00%> (-67.75%) ⬇️
limits/storage/gae_memcached.py 32.00% <0.00%> (-60.00%) ⬇️
limits/storage/redis_cluster.py 40.00% <0.00%> (-60.00%) ⬇️
limits/util.py 40.74% <0.00%> (-59.26%) ⬇️
limits/storage/redis.py 44.26% <0.00%> (-55.74%) ⬇️
limits/strategies.py 72.97% <0.00%> (-27.03%) ⬇️
limits/storage/memory.py 76.25% <0.00%> (-23.75%) ⬇️
limits/limits.py 91.66% <0.00%> (-8.34%) ⬇️
limits/storage/registry.py 87.50% <0.00%> (-6.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b153c7...7c9620f. Read the comment docs.

- Make tests plain functions when possible
- Remove unittest.TestCase subclassing and use plain
  classes instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants