Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: move navbar and footer creation to js to resolve #31 #32

Merged
merged 1 commit into from
Apr 22, 2022
Merged

feat: move navbar and footer creation to js to resolve #31 #32

merged 1 commit into from
Apr 22, 2022

Conversation

nlenno1
Copy link
Collaborator

@nlenno1 nlenno1 commented Apr 22, 2022

Move NavBar and Footer to JS

Pull Request References:

#31

PR Includes:

  • Moving the HTML code for the Navbar and Footer to a JS file
  • Calling the innerHTML function to create the elements inside the element containers
  • Add script links to all pages to call functions
  • Remove the original html elements from all pages

ADDITIONS

UPDATES

DELETED/REMOVED ITEMS/FEATURES

Breaking changes

None

Screenshots/Gifs/Media

None

alissatroiano
alissatroiano approved these changes Apr 22, 2022
View reviewed changes
Copy link
Owner

@alissatroiano alissatroiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work here... this is SO much better than just copying and pasting the same header and footer in every single page

@alissatroiano alissatroiano merged commit 09020bd into main Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alissatroiano alissatroiano alissatroiano approved these changes

@wierdlygoodcoder wierdlygoodcoder Awaiting requested review from wierdlygoodcoder

@Darlyn-Lurikah Darlyn-Lurikah Awaiting requested review from Darlyn-Lurikah

@ClaudiaLie ClaudiaLie Awaiting requested review from ClaudiaLie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nlenno1 @alissatroiano