Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Claudia branch #43

Merged
merged 3 commits into from
Apr 23, 2022
Merged

Claudia branch #43

merged 3 commits into from
Apr 23, 2022

Conversation

ClaudiaLie
Copy link
Collaborator

#34

Pull Request References:

PR Includes:

  • Styling of the footer
  • Styling of the navbar
  • Styling of the quiz page
  • First styling of the team page

ADDITIONS

  • Cards for the team page as first suggestion of future look for the page

UPDATES

  • Updated overall the fonts and buttons in order to give continuity to the website
  • Shadows on the quiz cards
  • Updated hyperlinks in the footer to navigate the website
  • Note that the social links are not completed (More styling will follow in the upcoming PRs)

DELETED/REMOVED ITEMS/FEATURES

  • None

Breaking changes

  • I had to merge again my local branch, the issue shouldn't concern the main branch but only my local one

Screenshots/Gifs/Media

image
image
image
image

@ClaudiaLie ClaudiaLie self-assigned this Apr 23, 2022
@ClaudiaLie ClaudiaLie added this to In progress in Team_4 via automation Apr 23, 2022
@ClaudiaLie ClaudiaLie requested a review from nlenno1 April 23, 2022 12:15
nlenno1
nlenno1 approved these changes Apr 23, 2022
View reviewed changes
Copy link
Collaborator

@nlenno1 nlenno1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nlenno1 nlenno1 merged commit 15563f7 into main Apr 23, 2022
Team_4 automation moved this from In progress to Done Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlenno1 nlenno1 nlenno1 approved these changes

@alissatroiano alissatroiano Awaiting requested review from alissatroiano

@Darlyn-Lurikah Darlyn-Lurikah Awaiting requested review from Darlyn-Lurikah

Assignees

@ClaudiaLie ClaudiaLie

Labels
None yet
Projects
Team_4
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ClaudiaLie @nlenno1