Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set the height of artplayer automatically #134

Merged
merged 5 commits into from Jan 18, 2024
Merged

feat: set the height of artplayer automatically #134

merged 5 commits into from Jan 18, 2024

Conversation

liuycy
Copy link
Member

@liuycy liuycy commented Jan 11, 2024

启用播放器自动设置高度,播放时可以去除黑边
image
image

@xhofe
Copy link
Member

xhofe commented Jan 17, 2024

我记得这样好像在播放竖屏视频的时候就会因为视频太长导致超出屏幕,所以才固定高度的。

@pull-request-size pull-request-size bot added size/M and removed size/S labels Jan 17, 2024
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我记得这样好像在播放竖屏视频的时候就会因为视频太长导致超出屏幕,所以才固定高度的。

在这个组件里加了兼容处理,给播放器父级容器设置里最大高度和最小高度,确保播放器能完整地显示在屏幕内

2 1

@xhofe xhofe merged commit 8f6258a into alist-org:main Jan 18, 2024
4 checks passed
@anwen-anyi
Copy link
Member

这样的话如果视频无法播放直接这样了 😹
image

@liuycy
Copy link
Member Author

liuycy commented Jan 26, 2024

这样的话如果视频无法播放直接这样了 😹 image

可以把这个视频分享一下不,是那种浏览器无法直接解码的视频吗?
这种情况的话,我后面再提个 PR 加个提示,说明视频无法播放,引导用户使用本地播放器播放,处理一下吧

@anwen-anyi
Copy link
Member

这样的话如果视频无法播放直接这样了 😹 image

可以把这个视频分享一下不,是那种浏览器无法直接解码的视频吗?

这种情况的话,我后面再提个 PR 加个提示,说明视频无法播放,引导用户使用本地播放器播放,处理一下吧

对的 编码问题 视频你随便打开一个就可以截图😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants