feat: add Google Photo support #1853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! Please check out our contributing guidelines. |
xhofe
reviewed
Sep 30, 2022
| } | ||
|
|
||
| func (d *GooglePhoto) List(ctx context.Context, dir model.Obj, args model.ListArgs) ([]model.Obj, error) { | ||
| files, err := d.getFiles() |
There was a problem hiding this comment.
根据谷歌提供的api来说，除了列出所有，或者通过手动进行搜索条件筛选列出、列出影集这几种。
我这边也review了一下rclone的做法，他们那边好像也是遍历分日期、影集、全部这三种方式展示全部文件（包括重复的情况）。
| var config = driver.Config{ | ||
| Name: "GooglePhoto", | ||
| OnlyProxy: true, | ||
| DefaultRoot: "root", |
There was a problem hiding this comment.
如果Google photo没有排序的方法的话，可以在这里加上LocalSort:true以使用本地排序。
谷歌相册好像目前只有影集这种目录的情况，但是需要手动在相册app添加相片至影集才行。 |
|
Congrats on merging your first pull request! We here at behavior bot are proud of you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
增加对谷歌相册的支持。
谷歌相册api相当的多限制，只能支持下载和上传，其他操作基本上没了。
还有几个问题：
可以改进的地方：