Perf upload and cache #4965
Merged
Perf upload and cache #4965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanHeuc
reviewed
Aug 9, 2023
| @@ -211,6 +221,11 @@ func (d *BaiduPhoto) Remove(ctx context.Context, obj model.Obj) error { | |||
| } | |||
|
|
|||
| func (d *BaiduPhoto) Put(ctx context.Context, dstDir model.Obj, stream model.FileStreamer, up driver.UpdateProgress) (model.Obj, error) { | |||
| // 不支持大小为0的文件 | |||
There was a problem hiding this comment.
is this limitation of baidu_photo?
SeanHeuc
reviewed
Aug 9, 2023
drivers/aliyundrive_open/types.go
Outdated
| } | ||
|
|
||
| func fileToObj(f File) *model.ObjThumb { | ||
| return &model.ObjThumb{ | ||
| Object: model.Object{ | ||
| ID: f.FileId, | ||
| Name: f.Name, | ||
| Name: f.Name + f.FileName, |
There was a problem hiding this comment.
is this correct? if yes, can we at least add some logic of handling both of them not being empty?
There was a problem hiding this comment.
逻辑上是没有问题的，Name和FileName只会返回一个
There was a problem hiding this comment.
逻辑上是没有问题的，Name和FileName只会返回一个
建议使用 两者不为空的一个且仅一个
SeanHeuc
reviewed
Aug 9, 2023
| preTime = time.Now() | ||
| } | ||
| } | ||
| func (d *AliyundriveOpen) completeUpload(fileId, uploadId string) (model.Obj, error) { |
There was a problem hiding this comment.
can we also handle the context here? just in case it's canceled
There was a problem hiding this comment.
虽然我认为这些非耗时操作没有必要使用context，但如果有需要也可以加上
xhofe
approved these changes
Aug 9, 2023
|
暂时就改这些了，其他的不是没号就是空间有限不好测试了。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
不得不说crypt真好用，为此优化几个常用的存储驱动
特别是百度和阿里的api真脆弱，时不时就报错