Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to fix #4981 #5028

Merged
merged 1 commit into from
Aug 19, 2023
Merged

try to fix #4981 #5028

merged 1 commit into from
Aug 19, 2023

Conversation

xhofe
Copy link
Member

@xhofe xhofe commented Aug 17, 2023

try to fix #4981:

Fixed the issue that copy tasks using multi-threaded downloaders could not be canceled

@foxxorcat
Copy link
Member

没想到又是这种问题😓。
不过像这种使用场景或许可以写个池复用bytes.Buffer避免高并发时频繁创建,可以参考 https://github.com/valyala/bytebufferpool

@xhofe
Copy link
Member Author

xhofe commented Aug 17, 2023

不知道有没有修复 #4981 还需要测试一下

@SeanHeuc
Copy link
Member

改的很好,但是问题好像并不在buffer的内存分配上,貌似是和copy有关。 近期有多个人使用新版遇到了变慢的问题,重启可以解决,昨晚有一个人的情况是本地代理阿里云盘,新版本频繁快进(产生新的range请求),会很快被限速到100kb/s左右,旧版3.24不会触发限速,但是新版一旦被触发了限速,同一台机器的旧版也被影响了,重启新版alist会解除两个版本的限速。这个现象还是比较奇怪的,而且阿里云的本地代理逻辑也很简单,我暂时猜测是copy 和close的问题。
另外一个就是多个出现问题的例子中,都没有内存占用率问题,但是cpu占用率很高很常见。

@xhofe xhofe marked this pull request as ready for review August 18, 2023 06:34
@xhofe xhofe merged commit 1e3950c into main Aug 19, 2023
2 checks passed
@xhofe xhofe added this to the v3.26.0 milestone Aug 19, 2023
@xhofe xhofe deleted the fix/4981 branch October 4, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

挂载夸克播放有问题,阿里云open正常播放,播放70g的原盘都可以
3 participants