Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lhapdf should disable python, if python3 is installed #2472

Closed
wants to merge 1 commit into from

Conversation

martenole
Copy link
Contributor

Hi @ktf ,

probably I am wrong, but isn't there an error in the check for the python version in lhapdf.sh? In case python3 is detected, python should be disabled, but I think it is the other way around currently.

Cheers,
Ole

@martenole martenole requested a review from a team as a code owner September 8, 2020 10:14
@ghost ghost requested a review from sawenzel September 8, 2020 10:14
@preghenella
Copy link
Contributor

it looks to me that the code is correct as it is.
you can check running it with

preghenella@RobyThinkPad:~$ if python -c 'import sys; exit(0 if sys.version_info.major >=3 else 1)'; then echo "PYTHON version is > 3"; fi

which does not echo anything, whereas

if python3 -c 'import sys; exit(0 if sys.version_info.major >=3 else 1)'; then echo "PYTHON version is >= 3"; fi
PYTHON version is >= 3

Copy link
Contributor

@preghenella preghenella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to me the code looks ok as it is

@martenole
Copy link
Contributor Author

Sorry about that, you are right. I will close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants