Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ofi to prevent issues with the new version on old platforms (O2-2752) #3772

Merged
merged 1 commit into from
Jan 25, 2022

Conversation

ktf
Copy link
Member

@ktf ktf commented Jan 25, 2022

No description provided.

@ktf ktf requested a review from a team as a code owner January 25, 2022 08:23
@ktf
Copy link
Member Author

ktf commented Jan 25, 2022

@ironMann @davidrohr @vascobarroso any objections to this? it looks like suddenly ofi does not compile anymore on different platforms (probably due to an update of libatomic on the system).

@Barthelemy
Copy link
Contributor

O2-2752

@ktf ktf changed the title Update ofi to prevent issues with the new version on old platforms Update ofi to prevent issues with the new version on old platforms (O2-2752) Jan 25, 2022
Copy link
Contributor

@davidrohr davidrohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, don't see a problem if it passes the FullCI

@awegrzyn
Copy link
Collaborator

On FLP production setups we use libfabric from CS8 (1.14.0-1) so this won't change anything for us.

@ktf
Copy link
Member Author

ktf commented Jan 25, 2022

Ok, then even better.

@ironMann
Copy link
Collaborator

cc @dennisklein

@ktf
Copy link
Member Author

ktf commented Jan 25, 2022

Do we actually use the libfabric we ship in alidist anywhere? Maybe we should just drop it, if no one is actually using it.

@ktf ktf merged commit a7ff727 into master Jan 25, 2022
@ktf ktf deleted the ktf-patch-25 branch January 25, 2022 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants