XRootD update to 5.6.0 #5075
XRootD update to 5.6.0 #5075
Conversation
Notes: - Option ENABLE_CRYPTO has been removed. It is always enabled/required. - Options ENABLE_PERL and VOMSXRD_SUBMODULE do not exist since a while. - CMake now uses the new FindPython.cmake module, so need to update PYTHON_EXECUTABLE to Python_EXECUTABLE. - Python bindings build system has been completely rewritten, now follows PEP517. - Using CMAKE_CXX_FLAGS_RELWITHDEBINFO overwrites the default -O2 -g, so it means you may get a build without optimizations. It's better to use just CMAKE_CXX_FLAGS to add -Wno-error to the default flags.
There was a problem hiding this comment.
Hi @amadio, thanks, looks good to me in general except for one thing: setting CMAKE_CXX_FLAGS_RELWITHDEBINFO is intentional I think, since we already set the CXXFLAGS environment variable here, and this change to -DCMAKE_CXX_FLAGS would wipe that out. That also contains -O2, so we get an optimised build already!
Approving so that the CI tests can run.
This should avoid undeclared runtime dependencies on libintl/gettext.
On Mac, we use our UUID anyway since we depend on AliEn-Runtime, which depends on UUID, and UUID sets PKG_CONFIG_PATH so we find it even with UUID_ROOT unset. This is counter-intuitive, so stop fiddling with UUID_ROOT manually.
|
...and cherry-picked the UUID commits from #5066. |
|
@TimoWilken i would also disable XRDCLHTTP Also, just to build only what we use i would also go with ENABLE_KRB5=Off ENABLE_FUSE=Off ENABLE_VOMS=Off |
|
@adriansev Fine by me if it won't break anything at runtime. |
@TimoWilken no, XRDCLHTTP is the davix based client component for using http endpoints .. we are using only curl for this, and we never have davix installed as dependency (and when davix is installed as system macos lib then there will be problems) |
|
Alright. Can you push here or should I @adriansev? |
CXXFLAGS is set in defaults-o2.sh. We only want to add it it, not replace it.
could you please do it @TimoWilken ? I'm currently in holyday and it would take some time to do the procedure |
Ah, thank you for the clarification. I see you already added a change to revert my change, so I will leave things as they are. |
|
@TimoWilken the only test that failed is in QC with the test showing: is this a pass or it requires a test restart? |
|
Good morning @TimoWilken ! the tests are green 😃 |
|
I'm going to release 5.6.1 today or tomorrow with a fix for the uuid problem in case you'd like to wait. |
|
@adriansev @amadio Thank you! I'll merge this PR later this morning because it works. Then we can update to v5.6.1 once it's out, so no rush! |
Notes:
This still likely won't solve the problem with uuid, but should be worth picking up before updating that. Please check build options here, there may be things like erasure coding support which you may want to enable (dependencies requires are listed in the same file).