-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for problems in rivet-config
, rivet-build
and fastjet-config
#5320
Conversation
…rivet-config`, `rivet-build`, and - I suspect - `fastjet-config`. See also alisw#5245 for a discussion. Note, the `rivet.sh` script is set up to explicitly fail - thus hopefully allowing me to see the log output. This is work-in-progress.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the changes to fix Rivet deployment
@jackal1-66 and @ktf Please see this test MR for more on figuring out what's up with the Rivet deployment. This is really a test MR to see if I can deduce from the build logs whats going on. I hope we will get the build logs. If not, is there some other way we can get at them? Thanks. |
Whoops, a little early I think. The |
@cholmcc I thought some tests couldn't start without an approved review (as for other packages), Of course I didn't approve the full merge ;) |
OK, I see - thanks. |
Maybe it's the WIP in the title - I'll remove that 😄 |
Still not running - will try to do "Ready for review" - should still not be merged |
The combination of special handling for GMP and CGal seems to do the trick, together with the update to the fastjet build script. Note, we may not need the special handling anymore, but I leave it in in case we are building against an older fastjet distribution.
Hi, I pushed a new commit. This time I believe it fixed the issue - at least from what I saw in the last log. It seems that the special handling of GMP and CGal, together with the updates to the If this passes the CI tests, I think it is ready for deployment. Thanks. |
|
Even though the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good to me, just a small comment ont he last EOF of the rivet.sh script which seems not to serve a purpose
@ktf could you please review the changes? Your approval is required to fix this issue. |
rivet-config
, rivet-build
and fastjet-config
- fastjet module need to load GMP to make sure we use the right version - Fix a typo in generated environment script for Rivet
Head branch was pushed to by a user without write access
Neither failure of |
Got it 😄 - well almost. The However
so the Yours, |
BTW, just doing
doesn't select the newest install ( Yours, |
...
rivet-config
,rivet-build
, and - I suspect -fastjet-config
.See also #5245 for a discussion.
Note, therivet.sh
script is set up to explicitly fail - thus hopefully allowing me to see the log output.This is work-in-progress.