Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pasargad driver | resovles #13 #20

Merged
merged 20 commits into from Sep 9, 2022
Merged

Pasargad driver | resovles #13 #20

merged 20 commits into from Sep 9, 2022

Conversation

Keivan-sf
Copy link
Collaborator

@Keivan-sf Keivan-sf commented Sep 8, 2022

resolves #13

The Pasargad driver and it's Api are implemented via Pasargad documents , Pasargad SKDs , Pasargad Swagger and the unit tests are provided.

However, I can say with confidence, even though I've surfed through the pasargad documentation and every sdk of this bank, this driver is likely to fail while interacting with the real api and there are several reasons for it:

  • Swagger examples are not in agreement with documents examples
  • SDK's are not in agreement with each other (There are differences between PHP and Nodejs SDK and so on ...)
  • From how it looks, Pasargad Official Nodejs SDK will fail in real tests and is likely to have been never tested before
  • Some properties are not even considered in the SDK's, but mentioned in the documentation

Anyway, I'm trying to contact their developer of the Nodejs SDK and get some pull requests merged to fix it.

This driver is built upon the most used SDK (php sdk) and the documentation but still I am not sure what Pasargad has in store for us. I guess we'll never know until someone tests it IRL.

The current problems:

  • Pasargad, due to the examples, doesn't provide any error codes. so the error messages are all the same
  • PrivateKey is provided as an rsa-xml file by Pasargad, while the driver needs the pem version. So the developers have to convert it in order to use the driver (Via libraries or online converters). I was unable to find a reliable way to convert them in driver
  • There is no exception if the signing process fails (this applies to other drivers as well). And the crypto errors are inconvenient for a developer who does not know about the signing process

I'll submit and track the problems in issues section.

Sorry for the long description

@Keivan-sf Keivan-sf marked this pull request as draft September 8, 2022 17:33
@Keivan-sf Keivan-sf marked this pull request as ready for review September 8, 2022 17:37
@alitnk alitnk self-requested a review September 9, 2022 09:05
@alitnk alitnk merged commit c0b45c4 into alitnk:main Sep 9, 2022
@alitnk alitnk mentioned this pull request Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

پشتیبانی از درگاه پاسارگاد
2 participants