Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of tasks submitted to a stopped pool #22

Merged
merged 2 commits into from Dec 26, 2021
Merged

Conversation

alitto
Copy link
Owner

@alitto alitto commented Dec 26, 2021

Changes included

  • Improve handling of tasks submitted to a stopped pool
    • Sending a task using Submit() will panic with ErrSubmitOnStoppedPool if the pool has been stopped.
    • Sending a task using TrySubmit() will return false if the pool has been stopped.
  • Update dependencies in benchmark package

@codecov-commenter
Copy link

codecov-commenter commented Dec 26, 2021

Codecov Report

Merging #22 (f833392) into master (a646d99) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
+ Coverage   98.52%   98.57%   +0.04%     
==========================================
  Files           2        2              
  Lines         203      210       +7     
==========================================
+ Hits          200      207       +7     
  Misses          3        3              
Impacted Files Coverage Δ
pond.go 98.47% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a646d99...f833392. Read the comment docs.

@alitto alitto merged commit 9d7bd8f into master Dec 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants