Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(bugfix) [3.5.1.7] 'enable_firewall' flag applied to all 'ufw' tasks #31

Merged
merged 1 commit into from
Feb 2, 2021
Merged

(bugfix) [3.5.1.7] 'enable_firewall' flag applied to all 'ufw' tasks #31

merged 1 commit into from
Feb 2, 2021

Conversation

jvleminc
Copy link
Collaborator

@jvleminc jvleminc commented Feb 2, 2021 •
edited

enable_firewall should apply to all ufw rules in task 3.5.1.7

The following task didn't have the "when: enable_firewall" condition set.

    - name: Enable UFW
      ufw:
        state: enabled
        policy: allow

@jvleminc jvleminc requested a review from alivx February 2, 2021 17:13
@jvleminc jvleminc changed the title (bugfix) 'enable_firewall' flag applied to all 'ufw' tasks (bugfix) [3.5.1.7] 'enable_firewall' flag applied to all 'ufw' tasks Feb 2, 2021
@alivx alivx merged commit 13fe423 into master Feb 2, 2021
@jvleminc jvleminc deleted the bugfix/enable_ufw_only_when_enable_firewall branch February 3, 2021 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alivx alivx alivx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jvleminc @alivx